Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Update ACR module api version to 2022-02-01-preview #2037

Merged
merged 9 commits into from
Sep 20, 2022

Conversation

tyconsulting
Copy link
Contributor

@tyconsulting tyconsulting commented Sep 16, 2022

Description

Update Azure Container Registry API version to 2022-02-01-preview with additional properties:

  • azureADAuthenticationAsArmPolicyStatus
  • softDeletePolicyStatus
  • softDeletePolicyDays

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

| Pipeline |
ContainerRegistry: Registries
| |

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ghost
Copy link

ghost commented Sep 16, 2022

CLA assistant check
All CLA requirements met.

@tyconsulting tyconsulting marked this pull request as ready for review September 16, 2022 08:25
@tyconsulting tyconsulting requested a review from a team as a code owner September 16, 2022 08:25
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @tyconsulting . Can you please trigger a successful run on your fork: https://github.com/TY-Consulting/ResourceModules/actions/runs/3067028859/jobs/4952870833

@ahmadabdalla ahmadabdalla added [cat] modules category: modules enhancement New feature or request labels Sep 16, 2022
@eriqua eriqua changed the title update ACR module api version to 2022-02-01-preview [Modules] Update ACR module api version to 2022-02-01-preview Sep 17, 2022
@tyconsulting
Copy link
Contributor Author

Thank you for your contribution @tyconsulting . Can you please trigger a successful run on your fork: https://github.com/TY-Consulting/ResourceModules/actions/runs/3067028859/jobs/4952870833

updated

@tyconsulting
Copy link
Contributor Author

@MrMCake @ahmadabdalla please review this PR again. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Uplift ACR module to use the latest API version 2022-02-01-preview
4 participants