-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Updated Network/VirtualHubs to new dependency approach #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
added
[cat] modules
category: modules
[cat] testing
category: testing
labels
Aug 30, 2022
Unit Test Results 1 files ± 0 1 suites ±0 56s ⏱️ +34s Results for commit a2d9ec4. ± Comparison against base commit 6bb70a5. This pull request removes 44 and adds 125 tests. Note that renamed tests count towards both.
This pull request removes 1 skipped test and adds 3 skipped tests. Note that renamed tests count towards both.
|
AlexanderSehr
commented
Sep 19, 2022
modules/Microsoft.Network/virtualHubs/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
AlexanderSehr
commented
Sep 19, 2022
modules/Microsoft.Network/virtualHubs/.test/min/deploy.test.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Sep 29, 2022
modules/Microsoft.Network/virtualHubs/.test/common/dependencies.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Sep 29, 2022
modules/Microsoft.Network/virtualHubs/.test/common/dependencies.bicep
Outdated
Show resolved
Hide resolved
eriqua
reviewed
Sep 29, 2022
modules/Microsoft.Network/virtualHubs/.test/min/dependencies.bicep
Outdated
Show resolved
Hide resolved
…s.bicep Co-authored-by: Erika Gressi <[email protected]>
…s.bicep Co-authored-by: Erika Gressi <[email protected]>
…icep Co-authored-by: Erika Gressi <[email protected]>
eriqua
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[cat] modules
category: modules
[cat] testing
category: testing
[prio] high
importance of the issue: high priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipeline references
Type of Change
Please delete options that are not relevant.