Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Utilities]: Enabled generation script to add Bicep + JSON deployment examples to readme V2 #1362

Merged
merged 43 commits into from
May 21, 2022
Merged

[Utilities]: Enabled generation script to add Bicep + JSON deployment examples to readme V2 #1362

merged 43 commits into from
May 21, 2022

Conversation

AlexanderSehr
Copy link
Contributor

Description

Enabled generation script to add Bicep + JSON deployment examples to readme -> Based on parameter files (1 each)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr marked this pull request as draft May 4, 2022 18:42
@AlexanderSehr AlexanderSehr self-assigned this May 4, 2022
This was linked to issues May 8, 2022
Module readmes - Add bicep parameter usage to module readmes #1179
Closed
Module readmes - Add an example section on how to use the module #1227
Closed
@AlexanderSehr AlexanderSehr linked an issue May 12, 2022 that may be closed by this pull request
Microsoft.Network - Subnetting is complex. Provide clarity #1276
Closed
@MariusStorhaug MariusStorhaug self-requested a review May 12, 2022 16:09
@AlexanderSehr AlexanderSehr mentioned this pull request May 17, 2022
Closed
MariusStorhaug
MariusStorhaug suggested changes May 18, 2022
View reviewed changes
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First check.

utilities/tools/Set-ModuleReadMe.ps1 Show resolved Hide resolved
utilities/tools/Set-ModuleReadMe.ps1 Outdated Show resolved Hide resolved
arm/Microsoft.AnalysisServices/servers/readme.md Outdated Show resolved Hide resolved
MariusStorhaug
MariusStorhaug previously approved these changes May 21, 2022
View reviewed changes
@AlexanderSehr AlexanderSehr merged commit 21d69ca into main May 21, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/readMeParamExampleParameterUsage branch May 21, 2022 01:27
@AlexanderSehr AlexanderSehr changed the title [ReadMe]: Enabled generation script to add Bicep + JSON deployment examples to readme V2 [Utilities]: Enabled generation script to add Bicep + JSON deployment examples to readme V2 Jun 17, 2022
@AlexanderSehr AlexanderSehr added the [cat] utilities category: utilities label Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] utilities category: utilities documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@AlexanderSehr @MariusStorhaug