Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added privateEndpoint bicep template(s) #132

Merged
merged 4 commits into from
Oct 6, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 6, 2021

Change

  • Added privateEndpoint bicep template(s)
  • Added RBAC
  • Added lock
  • Removed ARM template
  • Pipeline reference
    Network: Privateendpoints

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Unit Test Results

  1 files  ±  0    1 suites  ±0   10s ⏱️ +2s
38 tests +34  38 ✔️ +34  0 💤 ±  0  0 ±0 
42 runs   -   1  38 ✔️ +33  4 💤  - 34  0 ±0 

Results for commit 32446c1. ± Comparison against base commit 953e704.

This pull request removes 4 and adds 38 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [deployments] should use on of the recent API version(s). Currently using [2019-10-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [diagnosticSettings] should use on of the recent API version(s). Currently using [2017-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [trafficmanagerprofiles] used resource type [trafficmanagerprofiles] should use on of the recent API version(s). Currently using [2018-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.Delete lock should be implemented - if the resource type supports it
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.Diagnostic logs & metrics should be implemented - if the resource type supports them
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.Resource level RBAC should be implemented - if the resource type supports it
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.Tagging should be implemented - if the resource type supports them
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.The template should not have empty lines
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[privateEndpoints] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[privateEndpoints] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[privateEndpoints] CUA ID deployment should be present in the template
…

♻️ This comment has been updated with latest results.

README.md Outdated Show resolved Hide resolved
arm/Microsoft.Network/privateEndpoints/deploy.bicep Outdated Show resolved Hide resolved
testResults.xml Outdated Show resolved Hide resolved
@eriqua
Copy link
Contributor

eriqua commented Oct 6, 2021

Also in this case the readme content cannot be loaded
image

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit a5505e4 into main Oct 6, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/bicep_privateEndpoint branch October 6, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants