Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyvaults - Securing secrets parameter by using object #1022

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

vgaupset
Copy link
Contributor

@vgaupset vgaupset commented Feb 18, 2022

Change

Converting secrets parameter to secure object. The array type does not have the secure option and will therefore be displayed in plaintext in Azure portal (in deployments or export template).

Type of Change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    (Due to change from array to object)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ghost
Copy link

ghost commented Feb 18, 2022

CLA assistant check
All CLA requirements met.

@vgaupset vgaupset marked this pull request as ready for review February 21, 2022 08:06
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the parameters.json file.

"secrets": {
    "value": {
        "secureList": [
            {
                "name": "secretName",
                "value": "secretValue",
                "contentType": "Something",
                "attributesExp": 1702648632,
                "attributesNbf": 10000,
                "roleAssignments": [
                    {
                        "roleDefinitionIdOrName": "Reader",
                        "principalIds": [
                            "<<deploymentSpId>>"
                        ]
                    }
                ]
            }
        ]
    }
}

@AlexanderSehr AlexanderSehr added [cat] modules category: modules [prio] high importance of the issue: high priority labels Feb 21, 2022
@AlexanderSehr AlexanderSehr added this to the v 0.5 milestone Feb 21, 2022
@AlexanderSehr
Copy link
Contributor

Hey @vgaupset, thanks for the contribution. Just checked it out locally and suggested a few minor changes (rename + parameter file). Thanks for you contribution :)

@vgaupset
Copy link
Contributor Author

@MrMCake No problem :) I have changed the PR in compliance with requested changes.

@AlexanderSehr AlexanderSehr merged commit 42ea3fb into Azure:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [prio] high importance of the issue: high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants