Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage account - output issue for blob endpoint #860

Closed
MariusStorhaug opened this issue Jan 6, 2022 · 0 comments · Fixed by #861
Closed

Storage account - output issue for blob endpoint #860

MariusStorhaug opened this issue Jan 6, 2022 · 0 comments · Fixed by #861
Assignees
Labels
bug Something isn't working [cat] modules category: modules
Milestone

Comments

@MariusStorhaug
Copy link
Contributor

Description

The storage account module has the following output for blob endpoint:

@description('The primary blob endpoint reference if blob services are deployed.')
output storageAccountPrimaryBlobEndpoint string = (!empty(blobServices) && '' : contains(storageAccount_blobServices, 'blobContainers')) ? reference('Microsoft.Storage/storageAccounts/${storageAccount.name}', '2019-04-01').primaryEndpoints.blob

2 issues with this:

  • This the logic seems to be incorrect. Current logic in words, if we have blobServices and the module blobContains blobContainers, then return empty string, else return the ref for the blob endpoint.
  • The contains(storageAccount_blobServices, 'blobContainers')) is also invalid, as it will never be true. The return of the module will only contain name and outputs.
@MariusStorhaug MariusStorhaug added bug Something isn't working [cat] modules category: modules labels Jan 6, 2022
@MariusStorhaug MariusStorhaug self-assigned this Jan 6, 2022
@MariusStorhaug MariusStorhaug linked a pull request Jan 6, 2022 that will close this issue
10 tasks
@MariusStorhaug MariusStorhaug removed a link to a pull request Jan 6, 2022
10 tasks
@MariusStorhaug MariusStorhaug linked a pull request Jan 6, 2022 that will close this issue
10 tasks
@MariusStorhaug MariusStorhaug added this to the v 0.4 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant