Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add pipeline runtime parameters to test e.g. only pester tests #1372

Closed
AlexanderSehr opened this issue May 8, 2022 · 2 comments · Fixed by #2590
Closed
Assignees
Labels
[cat] pipelines category: pipelines enhancement New feature or request

Comments

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented May 8, 2022

Description

Add pipeline runtime parameters to test e.g. only pester tests.

If one is only working on Pester tests it is a bit unfortunate that one has also to run the deployment tests.

However, when adding such a parameter we have to make sure a module is still only published if all tests ran (-> Including the deployment tests). This could be achived by adjusting the publish-job condition to only run if 'needs.xzy' is in status succeeded. Thus, if a dependency would be skipped (and hence the status would indicate it as such) the publish would still not run.

@AlexanderSehr AlexanderSehr added the enhancement New feature or request label May 8, 2022
@AlexanderSehr AlexanderSehr added the [cat] pipelines category: pipelines label May 8, 2022
@AlexanderSehr
Copy link
Contributor Author

Tested a first implementation. While it is definetely possible with Azure DevOps, GitHub actions don't support conditional dependencies: https://github.com/Azure/ResourceModules/actions/runs/2457364409

As a result it is for example not possible to 'skip' the static validation, as the deployment validation will then refuse to run

@rahalan
Copy link
Contributor

rahalan commented Aug 4, 2022

Team decides to implement as @MrMCake suggested

@rahalan rahalan moved this to To do in Backlog Dec 11, 2022
@rahalan rahalan added this to Backlog Dec 11, 2022
@AlexanderSehr AlexanderSehr self-assigned this Jan 20, 2023
@AlexanderSehr AlexanderSehr moved this from To do to In progress in Backlog Jan 20, 2023
@AlexanderSehr AlexanderSehr moved this from In progress to Ready for review in Backlog Jan 20, 2023
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Backlog Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] pipelines category: pipelines enhancement New feature or request
Projects
Status: Done
2 participants