fix(designer): Non-string literal values are casted as Strings Literals #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfroJoe759
changed the title
added 3 commits
June 14, 2024 10:21
… joebrown/bugs/curlyBracesAroundExpressionV3Designer
… joebrown/bugs/curlyBracesAroundExpressionV3Designer
Eric-B-Wu
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to be a string
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix
What is the current behavior? (You can also link to an open issue here)
Current behavior for the new designer encapsulates non-string values in curly braces which in terms treats them as string literals and actually can prevent flows from being saved when expressions are generated since it malforms them.
Bug: https://msazure.visualstudio.com/One/_workitems/edit/28265634/
The new behavior only encapsulates the value in curly braces if the value is a StringLiteral, in all other cases the curly braces are removed.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
This shouldn't introduce a breaking change.
Please Include Screenshots or Videos of the intended change:
