Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): Add base path for svgs and remove duplicated code #4958

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Jun 10, 2024

This pull request primarily focuses on streamlining the codebase in two files: openMonitoringViewBase.ts and vite.config.ts. The most significant changes include the removal of a method in the OpenMonitoringViewBase class and an adjustment to the configuration in vite.config.ts.

  • The getPanelOptions method was removed from the OpenMonitoringViewBase class. This method previously returned webview options for the panel. Its removal suggests that the default options are now being used or they're being defined elsewhere.
  • The configuration for Vite, a build tool used in the project, was modified. The base option was added and set to './', which changes the base public path when serving or building the project.

Before

image

After

Screenshot 2024-06-10 at 3 04 22 PM
Screenshot 2024-06-10 at 3 04 30 PM

@ccastrotrejo ccastrotrejo merged commit 47cf368 into main Jun 10, 2024
13 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/svgNotShowing branch June 10, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants