-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Introduce .NET 8 to custom code and extension dependencies #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takyyon
approved these changes
Jun 7, 2024
ccastrotrejo
added a commit
that referenced
this pull request
Jun 7, 2024
…ies (#4947) * Add validation for multiple dotnet versions * Add comments and return in the await * Fix command execution * Add version to switch to nuget based * Add code to differentiate .net7 and netfx * Add .NET8 files and creation file decision * Update to function * Add selfContained * Remove .NET 6 * Move target framework step after workspace type step * Remove nuget config file * Upgrade packages * Add new dotnetMulti prop for manifest * Update pack command to build all projects for extension * Add comments and remove extra wizard context property
ccastrotrejo
added a commit
that referenced
this pull request
Jun 10, 2024
* feat(vscode): Introduce .NET 8 to custom code and extension dependencies (#4947) * Add validation for multiple dotnet versions * Add comments and return in the await * Fix command execution * Add version to switch to nuget based * Add code to differentiate .net7 and netfx * Add .NET8 files and creation file decision * Update to function * Add selfContained * Remove .NET 6 * Move target framework step after workspace type step * Remove nuget config file * Upgrade packages * Add new dotnetMulti prop for manifest * Update pack command to build all projects for extension * Add comments and remove extra wizard context property * fix(vscode): Update Workflows Webjobs sdk version (#4952) Update Workflows Webjobs sdk version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to refactor the codebase, and enhance the functionality of the software. The most important changes include modifying the import statements to use TypeScript's type-only import syntax, restructuring the code to improve readability, and updating the code to handle multiple .NET versions.
Modified the import statement for
IFileSysTreeItem
to use TypeScript's type-only import syntax and improved the code structure for better readability.Updated the code to handle multiple .NET versions.
Updated the code to handle multiple .NET versions by adding
targetFramework
as a parameter and modifying the corresponding method calls.Added a new file to handle the selection of the target framework.
Added
TargetFrameworkStep
to the wizard steps to handle the selection of the target framework.Updated the code to handle multiple .NET versions.