Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(designer): Turn off spell check in editors #4902

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(designer): Turn off spell check in editors #4902

merged 1 commit into from
May 28, 2024

Conversation

hartra344
Copy link
Contributor

This pull request includes a change to the BaseEditor component in the libs/designer-ui/src/lib/editor/base/index.tsx file. The spellCheck attribute has been added to the ContentEditable component and set to false. This change will prevent the browser from checking the spelling within the ContentEditable component.

fixes #4861

@hartra344 hartra344 marked this pull request as ready for review May 28, 2024 20:29
@hartra344 hartra344 enabled auto-merge (squash) May 28, 2024 20:30
@github-actions GitHub Actions
Copy link

Code Coverage Report

Code Coverage

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 21.56% 🟢 26.03% 🟢 4.47%

Minimum allowed coverage is 0%, this run produced 26.03%

@hartra344 hartra344 merged commit 6332975 into main May 28, 2024
12 checks passed
@hartra344 hartra344 deleted the turnOffSpellCheckInEditor branch June 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccastrotrejo ccastrotrejo ccastrotrejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design time squiggly lines for valid text in Odata query in v3 which does not show in v1
2 participants
@hartra344 @ccastrotrejo