Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer-ui): Allow color picker sliders to be accessed by keyboard #4884

Merged
merged 3 commits into from
May 24, 2024

Conversation

ek68794998
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix (a11y)

  • What is the current behavior? (You can also link to an open issue here)

Color picker hex field and palette buttons can be accessed by keyboard, but the two sliders cannot.

  • What is the new behavior (if this is a feature change)?

All fields of the color picker can now be accessed by keyboard, and controlled using arrow keys (and optionally +shift to move a larger distance at once).

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Please Include Screenshots or Videos of the intended change:

picker-all-fields

@ek68794998 ek68794998 requested review from rllyy97 and Eric-B-Wu May 23, 2024 22:13
@ek68794998 ek68794998 marked this pull request as ready for review May 23, 2024 22:15
Copy link
Contributor

@rllyy97 rllyy97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!

@ek68794998 ek68794998 merged commit 98fb4bc into Azure:main May 24, 2024
11 of 12 checks passed
@ek68794998 ek68794998 deleted the ek/key-picker branch May 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants