-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Data Mapper V2): Starting on functions panel #4835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielleCogs
changed the title
Feat (Data Mapper V2): Starting on functions panel
Feat(Data Mapper V2): Starting on functions panel
May 13, 2024
takyyon
reviewed
May 14, 2024
libs/data-mapper-v2/src/components/functionList/FunctionListItem.tsx
Outdated
Show resolved
Hide resolved
takyyon
reviewed
May 14, 2024
libs/data-mapper-v2/src/components/functionList/FunctionListItem.tsx
Outdated
Show resolved
Hide resolved
takyyon
reviewed
May 14, 2024
takyyon
reviewed
May 14, 2024
takyyon
reviewed
May 14, 2024
break; | ||
} | ||
} | ||
|
||
console.log(icon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: console.log
ccastrotrejo
approved these changes
May 14, 2024
Code Coverage Report
Minimum allowed coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
no functions in v2; three sources of icons- Fluent v8, Fluent v9 and SVG
converted old Function list into new Fluent v9 tree, added new styling and cleaned up old icons- removed all references to Fluent v8 icons and replaced them with new V9 or SVGs
no