Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): fix turbo dependency for vscode build setup #4772

Merged
merged 2 commits into from
May 4, 2024

Conversation

hartra344
Copy link
Contributor

CleanShot.2024-05-03.at.17.21.05.mp4

This pull request primarily involves changes to the build scripts in the package.json files of the vs-code-designer and vs-code-react applications, as well as modifications to the turbo.json file. The main changes include the removal of the build:vscode-react script from the vs-code-designer application and its addition to the vs-code-react application, the removal of the build:vscode-react script from the root package.json file, and the addition of dependencies in the turbo.json file.

  • apps/vs-code-designer/package.json: The build:vscode-react script was removed from the build:extension script, indicating that the vs-code-react build is no longer part of the vs-code-designer build process.
  • apps/vs-code-react/package.json: The build:vscode-react script was renamed to build:extension, suggesting that the vs-code-react application now has its own build process separate from the vs-code-designer application.
  • package.json: The build:vscode-react script was removed from the root package.json file, further indicating that the vs-code-react build is now separate from the main build process.
  • turbo.json: The build:vscode-react pipeline was renamed to vscode-designer#build:extension and vscode-react#build:extension. The vscode-react#build:extension pipeline now depends on the vscode-designer#build:extension pipeline, meaning that the vscode-designer build must complete before the vscode-react build can start.

@hartra344 hartra344 requested a review from ccastrotrejo May 4, 2024 00:21
@hartra344 hartra344 enabled auto-merge (squash) May 4, 2024 00:22
@hartra344 hartra344 merged commit edb20ee into main May 4, 2024
11 checks passed
@hartra344 hartra344 deleted the vscodeDependencies branch May 4, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants