fix(designer): make searchTerm placeholder harder to translate so it's not accidently translated #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3972
This pull request primarily focuses on updating the localization strings and the corresponding usage in the codebase. The changes involve updating a string ID and its corresponding text and comment in the
Localize/lang/strings.jsonfile and updating the usage of this string in theSearchResultsGridcomponent in thesearchResult.tsxfile.Localization strings update:
Localize/lang/strings.json: The string IDVI7EqGand its text and comment have been removed, and a new string ID4hlqgKwith its corresponding text and comment have been added. The new string ID and text are used to display a message when no search results are found. [1] [2] [3] [4]Codebase update:
libs/designer-ui/src/lib/panel/recommendationpanel/searchResult.tsx: In theSearchResultsGridcomponent, the string ID and the placeholder in thedefaultMessageproperty have been updated to match the new string ID and text added in theLocalize/lang/strings.jsonfile.