Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex types are not decoded if using many types #2281

Closed
Haeavar opened this issue Jul 3, 2024 · 1 comment
Closed

Complex types are not decoded if using many types #2281

Haeavar opened this issue Jul 3, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@Haeavar
Copy link
Contributor

Haeavar commented Jul 3, 2024

Describe the bug
If the complex types loading takes longer than creating the subscriptions, the complex types are not decoded (complex type system is not available in the binary decoder).

To Reproduce
Steps to reproduce the behavior:

  1. Connect OpcPublisher to an aggregation OPC UA server with many types
  2. Create a dataset with complex types
  3. Observe that complex types are still binary encoded

Expected behavior
Complex types should be decoded

Additional context
Currently we have a bugfix on our own by adding an await GetComplexTypeSystemAsync in the OpcUaSubscription.SyncWithSessionInternalAsync. This is kind of a hack since the ISession does not provide such a method call (we need to cast it to OpcUaSession).
You might find a better place to fix this. You can give us a hint where is the best place to fix it and we can create a PR if you want.

image: mcr.microsoft.com/iotedge/opc-publisher:2.9.8

@marcschier marcschier added the bug Something isn't working label Jul 3, 2024
@marcschier marcschier added this to the 2.9.10 milestone Jul 3, 2024
@marcschier
Copy link
Collaborator

Good catch, thanks. Fixed in #2279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants