Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr should work in http instead of https #2119

Closed
xky0007 opened this issue Nov 20, 2023 · 1 comment
Closed

Dapr should work in http instead of https #2119

xky0007 opened this issue Nov 20, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@xky0007
Copy link

xky0007 commented Nov 20, 2023

Describe the bug

In the source code internal sealed class Dapr : ConfigureOptionBase<DaprOptions>

 // Permit the port to be set if provided, otherwise use defaults.
 if (properties.TryGetValue(GrpcPortKey, out var value) &&
     int.TryParse(value, CultureInfo.InvariantCulture, out var port))
 {
     options.GrpcEndpoint = "https://localhost:" + port;
 }

 if (properties.TryGetValue(HttpPortKey, out value) &&
     int.TryParse(value, CultureInfo.InvariantCulture, out port))
 {
     options.HttpEndpoint = "https://localhost:" + port;
 }

From the dapr API doc, it should use http instead of https. And after I changed https to http, #2109 is also solved. (Also need to change to GRPC protocol #2118 )

Thanks.

@marcschier marcschier added the feature request New feature or request label Nov 20, 2023
@marcschier marcschier modified the milestones: 2.9.4, 2.9.3 Nov 20, 2023
@marcschier marcschier added bug Something isn't working and removed feature request New feature or request labels Nov 20, 2023
@marcschier
Copy link
Collaborator

Many thanks for the contributions, more are certainly welcome in this area in particular. I added a "Scheme" key to the connection string to select http or https, the default is now "http". preview4 container image will be available later today. Keep it coming :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants