Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard Coded name value in policy "name": "default-sandbox-budget", #842

Closed
EelcoLabordus opened this issue Oct 26, 2021 · 1 comment · Fixed by #850
Closed

Hard Coded name value in policy "name": "default-sandbox-budget", #842

EelcoLabordus opened this issue Oct 26, 2021 · 1 comment · Fixed by #850
Assignees
Labels
engineering engineering work enhancement New feature or request

Comments

@EelcoLabordus
Copy link

When applying this policy all budgets are called default-sandbox-budget

Make this into a parameter.

@jtracey93 jtracey93 added engineering engineering work enhancement New feature or request labels Oct 26, 2021
@jtracey93 jtracey93 added the waiting for response Maintainers have replied and are awaiting a response from the bug/issue/feature creator label Oct 28, 2021
@jtracey93
Copy link
Collaborator

Thanks for raising this @EelcoLabordus, good spot.

Would you be willing to submit a PR to fix this and convert this to a parameter? Not a problem if not, we will add to the backlog to get it done, but just wanted to know so we don't duplicate effort.

Let me know

Thanks

Jack

@jtracey93 jtracey93 removed the waiting for response Maintainers have replied and are awaiting a response from the bug/issue/feature creator label Nov 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering engineering work enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants