Removing Gateway and StorageAccount domain attributes #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azoppiserpa
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
rajdeepc2792
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
LGTM!!
Assuming that the RP Config PR(https://msazure.visualstudio.com/DefaultCollection/AzureRedHatOpenShift/_git/RP-Config/pullrequest/11349130) doesn't impact any other pipeline.
Checked OIDC pipeline, AFAIR that was using StorageAccountDomain in past, but no dependency now.
fahlmant
approved these changes
Dec 4, 2024
tsatam
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-7792
What this PR does / why we need it:
Removes gateway storage account domain and storage account domain because they are no longer required as we migrated to managed boot diagnostics. Should have done this together with this other PR (https://msazure.visualstudio.com/DefaultCollection/AzureRedHatOpenShift/_git/RP-Config/pullrequest/11038960?_a=files) but missed it back then and went on vacations. Doing the cleanup properly now that I am back.
Test plan for issue:
I ran
go testonpkg/deploydirectory and unit tests passed.Is there any documentation that needs to be updated for this PR?
No, tech debt cleanup.
How do you know this will function as expected in production?
I'll see the PR checks and the pipeline results of the test environment if applicable.