Dynamic image tagging using PR-specific variables in Azure DevOps pip… #3974
+23
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhadapaithankar
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-9503-Image-Management-Tag
branch
6 times, most recently
from
301a07b
to
74a1941
Compare
|
lgtm |
slawande2
approved these changes
Nov 26, 2024
…eline. Fix: Add missing 'tag' parameter to ACR push template in Azure DevOps pipeline Modified the tag to trigger the pipeline using the GitHub PR Modified the tag to trigger the pipeline using the GitHub PR Modified the tag to trigger the pipeline using the GitHub PR Fix: Use GitHub PR number and commit SHA for dynamic tagging in Azure DevOps pipeline Fix: Use GitHub PR number and commit SHA for dynamic tagging in Azure DevOps pipeline Fix: Use GitHub PR number and commit SHA for dynamic tagging in Azure DevOps pipeline Fix: Use GitHub PR number and commit SHA for dynamic tagging in Azure DevOps pipeline Fix pipeline to dynamically generate valid Docker image tags using PR ID and commit hash with fallback mechanisms Fix pipeline to dynamically generate valid Docker image tags using PR ID and commit hash with fallback mechanisms Fix pipeline to dynamically generate valid Docker image tags using PR ID and commit hash with fallback mechanisms Fix pipeline to dynamically generate valid Docker image tags using PR ID and commit hash with fallback mechanisms Fix pipeline to dynamically generate valid Docker image tags using PR ID and commit hash with fallback mechanisms Fix pipeline to dynamically generate valid Docker image tags using PR ID and commit hash with fallback mechanisms Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch modified the tag logic Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch Added a new Extract_PR_Number job to parse the PR number from System.PullRequest.SourceBranch
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-9503-Image-Management-Tag
branch
from
24f4e82
to
f02d547
Compare
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rhamitarora
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
This PR addresses the need for improved image management in the pipeline by introducing PR-specific tagging for RP images. Currently, it can be challenging to trace images back to specific pull requests, which complicates troubleshooting and version management. This update standardizes image tags, supports artifact caching, and enables caching for dependent images, improving both efficiency and traceability.
Fixes: 9503
What this PR does / why we need it:
This PR adds several key enhancements to the CI pipeline:
(pr-${PR_NUMBER}-${GIT_COMMIT_SHA}). This improves traceability by linking images directly to the pull requests that generated them.Key benefits:
Test plan for issue:
Verify PR-specific tagging
(pr-${PR_NUMBER}-${GIT_COMMIT_SHA})in dev ACR, confirm artifact caching reuses previous buildsIs there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
N/A