MIWI cluster Dynamic Validation update for strict 1:1 matching for provided Platform Workload Identity to expected OCP Operators #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdeepc2792
added
hold
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-10859
branch
3 times, most recently
from
744b3ad
to
da1decc
Compare
|
Please rebase pull request. |
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-10859
branch
from
da1decc
to
305400e
Compare
rajdeepc2792
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter and
SudoBrendan
as code owners
rajdeepc2792
requested review from
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27 and
tsatam
as code owners
…cluster deletion flow
…d platform identity is found
…for unexpected platform workload identity
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-10859
branch
from
305400e
to
8fb81f7
Compare
rajdeepc2792
force-pushed
the
rajdeepc2792/ARO-10859
branch
from
8fb81f7
to
ec9136e
Compare
kimorris27
requested changes
Nov 26, 2024
| return api.NewCloudError(http.StatusBadRequest, api.CloudErrorCodeInvalidParameter, "identity", "The provided cluster identity is invalid; there should be exactly one.") | ||
| } | ||
|
|
||
| if operatorRolePresent && len(pwip.PlatformWorkloadIdentities) == 0 { | ||
| return api.NewCloudError(http.StatusBadRequest, api.CloudErrorCodeInvalidParameter, "properties.platformWorkloadIdentityProfile", "Platform workload identity profile cannot be empty.") |
There was a problem hiding this comment.
Suggested change
| return api.NewCloudError(http.StatusBadRequest, api.CloudErrorCodeInvalidParameter, "properties.platformWorkloadIdentityProfile", "Platform workload identity profile cannot be empty.") | |
| return api.NewCloudError(http.StatusBadRequest, api.CloudErrorCodeInvalidParameter, "properties.platformWorkloadIdentityProfile.platformWorkloadIdentities", "The set of platform workload identities cannot be empty.") |
Suggesting this change because the error message should point to the exact property that we're validating to make the message easily actionable.
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
E2E failed with a known flake that's already captured in our CI failure epic. I'll wait to run it again until Rajdeep responds to my most recent review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-10859
What this PR does / why we need it:
Test plan for issue:
[x] Unit tests were added/updated for the above implementation
[x] Create/Update MIWI cluster in local
[x] CI
[x] e2e
Is there any documentation that needs to be updated for this PR?
Not yet.
How do you know this will function as expected in production?
Feature is not in production yet.