feat: updates to fix Region name now being appended to azFw policy name #914

[jtracey93]

This pull request introduces several changes to the infra-as-code/bicep/modules/vwanConnectivity module, primarily focusing on the addition of new parameters and the restructuring of resource definitions to support different deployment styles for Azure Firewall policies. The most important changes include the introduction of the parAzFirewallPolicyDeploymentStyle parameter, the addition of custom names for Azure Firewall policies via parAzFirewallPolicyCustomName, and the refactoring of resource definitions to support both shared global and per-region deployment styles.

Why

This was needed to fix #914, but it also posed the question of how customers should deploy the Azure Firewall Policy in a multi region configuration, today the module would create a policy per region, but that may not be desired. Hence the module now supports, via this PR, the ability to chose between a PerRegion or SharedGlobal firewall policy deployment approach.

New Parameters and Types:

• Added parAzFirewallPolicyDeploymentStyle parameter to specify the deployment style of Azure Firewall policies (SharedGlobal or PerRegion). [1] [2] [3] [4]
• Introduced azFirewallPolicyDeploymentStyleType type to define the possible values for parAzFirewallPolicyDeploymentStyle.

Custom Names for Policies:

• Added parAzFirewallPolicyCustomName parameter to allow specifying custom names for Azure Firewall policies.

Resource Definitions Refactoring:

• Refactored resource definitions to support both shared global and per-region deployment styles for Azure Firewall policies. This includes the creation of new resources and locks based on the deployment style. [1] [2]
• Updated the resVhub, resVhubLock, resVhubRouteTable, resVhubRoutingIntent, resVpnGateway, resVpnGatewayLock, resErGateway, and resErGatewayLock resources to use a more consistent and readable array syntax. [1] [2] [3] [4] [5]

Output Adjustments:

• Modified output definitions to use a more consistent and readable array syntax. [1] [2]

Testing Evidence

vwanConnectivity.bicep - defaults with VPN, DDOS & EX disabled (for speed)

vwanConnectivity.bicep - Multi Region Param with VPN, DDOS & EX disabled (for speed) - one hub with custom FW policy name

[oZakari]

LGTM thanks @jtracey93

[oZakari]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).