-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multi region support for accelerator #857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, clearly work in progress, so feel free to ignore my comments as you likely have them on your todo list anyway.
…into multi-region
oZakari
changed the title
feat: Multi region initial PR
feat: Multi region support for accelerator
Sep 26, 2024
oZakari
force-pushed
the
multi-region
branch
from
September 26, 2024 17:47
745268e
to
07bc5a9
Compare
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
oZakari
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Creates necessary changes to ALZ-PowerShell-Config for Accelerator v2 to support multi-region deployments. Also, includes relevant parameter file for VWAN and hubnetworking module that supports deployments to 2 regions.
Finally, adds notice for the upcoming change to zone redundant configurations by default.
Related Issues/Work Items
Closes #675
Fixes AB#34223
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch