From 328fe859afee58db89b2109dc4d6915cef362219 Mon Sep 17 00:00:00 2001 From: Albert Tanure Date: Fri, 22 Nov 2024 16:21:24 +0100 Subject: [PATCH 1/2] Fix: Fixing parameters capital letters. --- .../Bicep/03-Network-Hub/parameters-main.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/parameters-main.json b/Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/parameters-main.json index 6f56bab6..b78a5604 100644 --- a/Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/parameters-main.json +++ b/Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/parameters-main.json @@ -42,16 +42,16 @@ "azureFirewallSubnetAddressPrefix": { "value": "10.0.1.0/26" }, - "AzureFirewallManagementSubnetName": { + "azureFirewallManagementSubnetName": { "value": "AzureFirewallManagementSubnet" }, - "AzureFirewallManagementSubnetAddressPrefix": { + "azureFirewallManagementSubnetAddressPrefix": { "value": "10.0.4.0/26" }, - "AzureBastionSubnetName": { + "azureBastionSubnetName": { "value": "AzureBastionSubnet" }, - "AzureBastionSubnetAddressPrefix": { + "azureBastionSubnetAddressPrefix": { "value": "10.0.2.0/27" }, "vmsubnetSubnetName": { From 6e6592794b7655bab9b09c583efb3c947a190cc8 Mon Sep 17 00:00:00 2001 From: Albert Tanure Date: Mon, 25 Nov 2024 16:46:50 +0100 Subject: [PATCH 2/2] Fix: Remove Unecessary github actions step for UDR on Bicep --- .github/workflows/1-deploy-infrastructure.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/workflows/1-deploy-infrastructure.yml b/.github/workflows/1-deploy-infrastructure.yml index f6447b03..0b5815a8 100644 --- a/.github/workflows/1-deploy-infrastructure.yml +++ b/.github/workflows/1-deploy-infrastructure.yml @@ -177,18 +177,6 @@ jobs: # STORAGE_ACCOUNT_NAME=$(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w 24 | head -n 1) echo 'STORAGE_ACCOUNT_NAME=s'$(uuidgen) | sed 's/-//g' | cut -c 1-45 >> $GITHUB_ENV - - name: Create User Defined Route - if: ${{ env.AZURE_SUBSCRIPTION_ID != '' }} - uses: azure/arm-deploy@v1 - with: - deploymentName: ESLZ-AKS-HUB-UDR - template: ${{ env.BICEP_ROOT_PATH }}03-Network-Hub/updateUDR.bicep - parameters: ${{ env.BICEP_ROOT_PATH }}03-Network-Hub/parameters-updateUDR.json - scope: subscription - region: ${{ env.DEPLOYMENT_LOCATION }} - subscriptionId: ${{ env.AZURE_SUBSCRIPTION_ID }} - resourceGroupName: ${{ env.HUB_RESOURCE_GROUP }} - failOnStdErr: false - name: Create Spoke uses: azure/arm-deploy@v1