Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixing parameters capital letters. #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tanure
Copy link

@tanure tanure commented Nov 22, 2024

This pull request includes a small change to the Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/parameters-main.json file. The change standardizes the naming convention for several parameters by converting them to camelCase. This change fix issues during the pipeline execution where some parameters are not found, even if the parameter file is defined.

  • Standardized parameter names to camelCase in parameters-main.json

@tanure
Copy link
Author

tanure commented Nov 25, 2024

Updating the Github actions deploy-infrastructure
This pull request includes changes to the deployment infrastructure and parameter naming conventions to improve consistency and remove unnecessary steps. The most important changes include removing the creation of a User Defined Route and standardizing parameter names in the network configuration files. The following files doesn't exist on the directory:

  • ${{ env.BICEP_ROOT_PATH }}03-Network-Hub/updateUDR.bicep
  • ${{ env.BICEP_ROOT_PATH }}03-Network-Hub/parameters-updateUDR.json

Apparently the UDR is creating inside the main.bicep file. The pipeline fails because of the missing files.

Changes to deployment infrastructure:

Parameter naming standardization:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant