-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation for Terraform All-in-One deployment #157
Open
HoussemDellai
wants to merge
14
commits into
Azure:main
Choose a base branch
from
HoussemDellai:tf-all-in-one
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalbers
reviewed
Nov 14, 2024
Scenarios/AKS-Secure-Baseline-PrivateCluster/Terraform/All-in-One/Readme.md
Outdated
Show resolved
Hide resolved
Do we have a test run of this running successfully? |
@asalbers let me know if you have any issues running this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new folder called All-in-One from which all 4 steps (03-Network-Hub, 04-Network-LZ, 05-AKS-Supporting and 06-AKS-Cluster) are deployed as modules in just one template.
The changes are beneficial because it simplifies the deployment process and reduces the number of steps required to deploy the infrastructure.
I've changed the config of the existing templates, added input variables that takes the resource ID from the resources created in previous modules.