allow public clusters, configuration of spoke network and byo hub #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mosabami
commented
Sep 27, 2024
•
mosabami
commented
- Allow deployment of spoke only (bring your own hub)
- Allow deployment of non private clusters by setting a parameter. only deploy private dns zone and private link if using private cluster
- Allow configuration spoke subnet prefixes in deploy to azure button mode, this also configures firewall rules to allow AKS deploy successfully
- Allow deploying multiple spokes to the same hub by making network peering name configurable
- minor bug fixes
mosabami
changed the title
AdonisLL
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.