Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this be a NuGet? #22

Open
plettb opened this issue Jun 29, 2024 · 1 comment
Open

Can this be a NuGet? #22

plettb opened this issue Jun 29, 2024 · 1 comment

Comments

@plettb
Copy link

plettb commented Jun 29, 2024

Is there a reason the "MSALClient" code isn't in a NuGet? (Or is it and I've just never found it?)

@bzd3y
Copy link

bzd3y commented Feb 3, 2025

I know it has been a long time, but this is a good question. I think the answer has to do with the fact that this sample project is somewhat misleading.

Here, the Nuget you would use are the 2 Microsoft.Identity.Client packages (and maybe a few others if you have other needs?).

This sample project makes it seem like a lot more needs to be done and code written to do it than is really needed. Excluding the Maui boilerplate code, probably 90% of the code in this project could be removed. I implemented the entire process in roughly 80 lines of code, ~3 methods, in essentially a single class/file. I might still be missing a few things, but essentially all you need is to implement the methods in the MSALClientHelper class, which can easily be a lot more compact than it is in this sample.

So, the reason it isn't a Nuget package is that there is nothing to actually make a package out of here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants