Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: REST API broken links, Int testing devcontainer upgrade #853

Conversation

ydaponte
Copy link
Contributor

Type of PR

  • Code changes
  • Test changes

Purpose

  • Fixing temporarily the REST API parking sensors broken links
  • Upgrading devcontainer for integration testing - debian version 12 and msodbcsql18
  • removing delete databricks cli line from main docker files as it fails on the rebuild container

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Launch devcontainer
  • deploy sample (deploy.sh)
  • configure git with adf
  • run ADF pipelines successfully

Issues Closed or Referenced

Copy link
Contributor

@LiliamLeme LiliamLeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydaponte as for the databricks. I would leave the removal in case someone has the old version installed. Though, After the removal then adding the installation. THat was the problem I run through... It removed, then when I started the ./deploy there was nothing there...

Something like this:

Check if Databricks already exists and remove it

RUN [ -f /usr/local/bin/databricks ] && rm /usr/local/bin/databricks || echo "File not found, skipping removal"

RUN mkdir /workspace
WORKDIR /workspace

Copy and run the post_create.sh script

COPY post_create.sh /workspace/post_create.sh
RUN chmod +x /workspace/post_create.sh
RUN /workspace/post_create.sh

@ydaponte
Copy link
Contributor Author

Thanks @LiliamLeme! As discussed in the phone - the devcontainer.json is the one running the post-create command. Also it is supposed to run when rebuilding as per the docker documentation here: https://code.visualstudio.com/docs/devcontainers/create-dev-container#_rebuild. Please if you find again the problem let me know and we open a specific issue for this one. Thanks again!

@ydaponte ydaponte merged commit d05244a into feat/fix-REST-API-broken-links-tmp Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants