Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails (username contains space) #84

Closed
christianhidber opened this issue Dec 17, 2020 · 3 comments · Fixed by Benjamin-KY/digital-twins-explorer#2
Closed
Assignees
Labels
bug Something isn't working fixed in development branch The bug has been addressed in the development branch

Comments

@christianhidber
Copy link

"npm install" failed on my win10 machine where my username contains a space (eg "john doe").
installation with a "space-less" username worked fine.

2020-12-17T14_31_33_435Z-debug.log

@jamescarpinter jamescarpinter self-assigned this Dec 18, 2020
@jamescarpinter jamescarpinter added the bug Something isn't working label Dec 18, 2020
@jamescarpinter
Copy link
Contributor

Thanks for reporting this issue. We will include a note in the readme as a short term fix.

I believe this issue has already been reported in the npm-force-resolutions repo. Our goal is to remove this dependency in due course once we have a long term fix for the underlying security issue.

@jamiewilbraham jamiewilbraham self-assigned this Mar 30, 2021
@jamiewilbraham jamiewilbraham added the fixed in development branch The bug has been addressed in the development branch label Mar 30, 2021
@jamiewilbraham
Copy link
Collaborator

HI @christianhidber

Due to the dependency above - for now, we have added a note to the documentation in the development branch (step 4).
https://github.com/Azure-Samples/digital-twins-explorer/blob/development/README.md#running-adt-explorer-locally

Will close once merged to main

thanks

@jamiewilbraham
Copy link
Collaborator

Closing as the fix is now in the new default main branch here: https://github.com/Azure-Samples/digital-twins-explorer

Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in development branch The bug has been addressed in the development branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants