Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upload to AI Search in Batches #1323

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

cmw2
Copy link
Contributor

@cmw2 cmw2 commented Sep 16, 2024

Purpose

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code

  • Follow steps document in Local Deployment

  • Test the code

    • Ingest a large file. My tested one had ~850 pages and was 18.5 Megs in size.

What to Check

Verify that the following are valid

  • All chunks should be in search index (can take a while)

Other Information

  • Modified existing upload test to pass with 1 batch.
  • Added another test to check for multiple batches.
  • Also had to do some code cleanup per black and flake8, though they conflicted in some rules so added exceptions in flake config file.

with flake8 ignore rules to allow black formatted code
Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   env_helper.py147695%256–258, 277–279
code/backend/batch/utilities/helpers/embedders
   push_embedder.py79198%93
TOTAL266559277% 

Tests Skipped Failures Errors Time
300 0 💤 0 ❌ 0 🔥 40.516s ⏱️

.flake8 Show resolved Hide resolved
Copy link
Collaborator

@adamdougal adamdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

@adamdougal adamdougal added this pull request to the merge queue Sep 26, 2024
Merged via the queue into Azure-Samples:main with commit 5d0a5d6 Sep 26, 2024
6 checks passed
Copy link

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch calls to AI Search to Support large PDFs
2 participants