-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This sample won't work if I use certificate as secret for my AAD app #37
Comments
@shiweiwei114 : yes this sample will also show how to use certs in the future |
@jmprieur thanks for the quick response! Do you have a ETA for that? I will come back to check by that time then. |
@shiweiwei114 : I'd like to come to this before the end of April. |
Hi |
It's on the backlog for Microsoft.Identity.Web, @amal-khalaf: |
Thanks Jean @jmprieur for your quick response - do you have an ETA on when this would be ready? |
@amal-khalaf : we are well aware that this is needed for first party. |
@jmprieur : so i will need to write my own implementation of TokenAcquistion class to handle the new certificate configuration |
This issue is for a: (mark with an
x
)Minimal steps to reproduce
In appsetting.json file, instead of putting AAD app secret for "ClientSecret", I put the Certificate Name. The sample won't run because in the Startup.cs file, when the app first runs:
services.AddAuthentication(AzureADDefaults.JwtBearerAuthenticationScheme)
.AddAzureADBearer(options => Configuration.Bind("AzureAd", options));
.AddAzureADBearer() is taking AzureADOptions as input, and this class doesn't have properties for certificate name. Thus, this sample is not supporting certificate as a secret for AAD app.
AzureADOptions class is from the package: Microsoft.AspNetCore.Authentication.AzureAD.UI.AzureADOptions
Any log messages given by the failure
Expected/desired behavior
Do I miss anything here? Or this sample will support certificate in the future?
OS and Version?
Versions
Mention any other details that might be useful
Please let me know if I am missing anything here, maybe this sample does support the certificate as secret.
The text was updated successfully, but these errors were encountered: