Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE next steps #147

Closed
Tracked by #145
signorecello opened this issue Jan 24, 2024 · 6 comments
Closed
Tracked by #145

SPIKE next steps #147

signorecello opened this issue Jan 24, 2024 · 6 comments
Assignees
Labels
Boilerplates Related with starters or boilerplates Engineering Stuff involving messing with source code

Comments

@signorecello
Copy link
Collaborator

No description provided.

@signorecello signorecello self-assigned this Jan 24, 2024
@signorecello signorecello added Engineering Stuff involving messing with source code Boilerplates Related with starters or boilerplates labels Jan 24, 2024
@signorecello
Copy link
Collaborator Author

So, here's where we're at:

Blank box

This one looks fine. I think it can easily make its way into a starter.

Blank-React

As mentioned in #134 this could use some stripping down, as it is quite opinionated on a bunch of features we would like the dev to be able to implement themselves. Here's the task list:

  • Remove konami code easter egg (lol)
  • Remove irrelevant terms and conditions page
  • Remove copy to clipboard buttons and stuff
  • Flatten every action into one page (no modals , no dropdown for selecting wallet, showing available actions, etc). One page is enough with the bare essential
  • Remove warning popups. Use alerts or toasters if something needs to succeed/fail
  • Turn function call handles into hooks
  • Refactor the contract to have one contract call and one view function. Make one button say "VIEW FUNCTION" that alerts a view value, and "CALL FUNCTION" with an input. Remove form validation.
  • Remove most of the styling

I believe in 1 day one should be able to make these changes and have a barebones react box

@critesjosh
Copy link
Collaborator

Follow up to this, did you get a chance to look into how much work it would be to add a UI testing framework?

@signorecello
Copy link
Collaborator Author

It's hard to know because I would have to learn how to use playwright so I'm gonna say a wrong figure 💯 maybe it could be worth refactoring this and then make a decision based on pessimistic estimates? I mean I never spent more than 2-3 days learning the basics of any new framework so I could say maybe EOW...

@signorecello
Copy link
Collaborator Author

IMO refactoring this to have two actual starters is already a win, and a fairly quick one at that. Adding a frontend test is just a good contrib to the codebase and would give us some peace of mind

@critesjosh
Copy link
Collaborator

Agree. The front-end testing shouldn't be a blocker for this.

@signorecello
Copy link
Collaborator Author

signorecello commented Jan 25, 2024

Closing this as I move to the refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Boilerplates Related with starters or boilerplates Engineering Stuff involving messing with source code
Projects
None yet
Development

No branches or pull requests

2 participants