Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether we can use the same grand product relations parameters for all instances #752

Closed
maramihali opened this issue Oct 16, 2023 · 2 comments
Closed

Investigate whether we can use the same grand product relations parameters for all instances #752

maramihali opened this issue Oct 16, 2023 · 2 comments
Assignees
@codygunton @maramihali
Milestone
Protogalaxy

Comments

@maramihali
Copy link
Contributor

No description provided.

@maramihali maramihali self-assigned this Oct 16, 2023
@maramihali maramihali added this to the Protogalaxy milestone Oct 16, 2023
@maramihali
Copy link
Contributor Author

maramihali commented Oct 20, 2023 •
edited
Loading

after discussions with the theory team, the outcome is that we have to fold relation parameters as well (because otherwise the protocol changes); @codygunton is working on implementing this

additionally, the signature of combiner changes here as relation parameters are taken from each instance: https://github.com/AztecProtocol/aztec-packages/blob/master/barretenberg/cpp/src/barretenberg/honk/proof_system/protogalaxy_prover.hpp#L219

@maramihali
Copy link
Contributor Author

closed by AztecProtocol/aztec-packages#2935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codygunton codygunton

@maramihali maramihali

Labels
None yet
Projects
None yet
Milestone
Protogalaxy
Development

No branches or pull requests
2 participants
@codygunton @maramihali