From e984cfdec5fd201c38fcec9ede134fb559cea737 Mon Sep 17 00:00:00 2001 From: ludamad Date: Fri, 8 Sep 2023 12:25:50 -0400 Subject: [PATCH 1/2] fix: work around intermittent acir issue --- .../cpp/barretenberg/acir_tests/run_acir_tests_browser.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh b/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh index dcb399cf973..2e138a6a738 100755 --- a/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh +++ b/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh @@ -9,7 +9,8 @@ cleanup() { trap cleanup SIGINT SIGTERM # Skipping firefox because this headless firefox is so slow. -export BROWSER=${BROWSER:-chrome,webkit} +#export BROWSER=${BROWSER:-chrome,webkit} # Skipping webkit as well due to intermittent errors +export BROWSER=${BROWSER:-chrome} # Can be "mt" or "st". THREAD_MODEL=${THREAD_MODEL:-mt} @@ -19,4 +20,4 @@ echo "Testing thread model: $THREAD_MODEL" (cd browser-test-app && yarn serve:dest:$THREAD_MODEL) > /dev/null 2>&1 & sleep 1 VERBOSE=1 BIN=./headless-test/bb.js.browser ./run_acir_tests.sh $@ -lsof -i ":8080" | awk 'NR>1 {print $2}' | xargs kill -9 \ No newline at end of file +lsof -i ":8080" | awk 'NR>1 {print $2}' | xargs kill -9 From 5c1a3b4e9a070b5f7d01a6f5483687c67eb0b72a Mon Sep 17 00:00:00 2001 From: ludamad Date: Fri, 8 Sep 2023 12:27:19 -0400 Subject: [PATCH 2/2] Update run_acir_tests_browser.sh --- circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh b/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh index 2e138a6a738..da81b9e1f69 100755 --- a/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh +++ b/circuits/cpp/barretenberg/acir_tests/run_acir_tests_browser.sh @@ -9,7 +9,8 @@ cleanup() { trap cleanup SIGINT SIGTERM # Skipping firefox because this headless firefox is so slow. -#export BROWSER=${BROWSER:-chrome,webkit} # Skipping webkit as well due to intermittent errors +# Skipping webkit as well due to intermittent errors, see https://github.com/AztecProtocol/aztec-packages/issues/2104 +#export BROWSER=${BROWSER:-chrome,webkit} export BROWSER=${BROWSER:-chrome} # Can be "mt" or "st".