Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(foundation): should error on attempt to convert negative bigint to buffer #981

Merged
merged 2 commits into from
Jul 6, 2023
Merged

fix(foundation): should error on attempt to convert negative bigint to buffer #981

merged 2 commits into from
Jul 6, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Jul 6, 2023

Description

Should error on attempt to convert negative bigint to buffer. Encountered this in a branch when intentionally using leafIndex -1 to flag commitments as transient.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@dbanks12 dbanks12 requested a review from ludamad July 6, 2023 18:45
@dbanks12 dbanks12 merged commit 6e0d658 into master Jul 6, 2023
@dbanks12 dbanks12 deleted the db/error-on-negative-bigint-tobuffer branch July 6, 2023 19:16
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbanks12 @ludamad