Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aztec Noir functions should be able to nullify pending commitments from list maintained in ACIR Simulator #920

Closed
Tracked by #512
dbanks12 opened this issue Jun 27, 2023 · 2 comments · Fixed by #1109
Closed
Tracked by #512

Aztec Noir functions should be able to nullify pending commitments from list maintained in ACIR Simulator #920

dbanks12 opened this issue Jun 27, 2023 · 2 comments · Fixed by #1109
Assignees
@dbanks12

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Jun 27, 2023 •
edited
Loading

In private_execution.ts, notifyNullifiedNote oracle call may need to output commitments of nullified notes (when a nullifier actually corresponds to a commitment) to enable nullifier<>pendingNote matching in simulator.

In client_execution_context.ts, need to prevent Noir from 'getting' any notes nullified in the current TX.
@dbanks12 dbanks12 added this to A3 Jun 27, 2023
@dbanks12 dbanks12 self-assigned this Jun 27, 2023
@dbanks12 dbanks12 converted this from a draft issue Jun 27, 2023
@dbanks12 dbanks12 added C-protocol-circuits Component: Protocol circuits (kernel & rollup) and removed C-protocol-circuits Component: Protocol circuits (kernel & rollup) labels Jun 27, 2023
@dbanks12 dbanks12 mentioned this issue Jun 27, 2023
Closed
@dbanks12 dbanks12 moved this from Todo to In Progress in A3 Jun 29, 2023
This was referenced Jun 30, 2023
Closed
Merged
@dbanks12 dbanks12 assigned dbanks12 and unassigned dbanks12 Jul 11, 2023
@dbanks12
Copy link
Collaborator Author

dbanks12 commented Jul 14, 2023 •
edited
Loading

This is already done!.... Let's just add this to one of the tests and close this ticket.

@dbanks12 dbanks12 changed the title [TS] Aztec Noir functions should be able to nullify pending commitments from list maintained in ACIR Simulator Aztec Noir functions should be able to nullify pending commitments from list maintained in ACIR Simulator Jul 17, 2023
@dbanks12 dbanks12 mentioned this issue Jul 19, 2023
Merged
6 tasks
@dbanks12
Copy link
Collaborator Author

Closed by #1109

@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(tests): add tests that you can nullify pending notes AztecProtocol/aztec-packages
2 participants
@iAmMichaelConnor @dbanks12