Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Download only non-pruned blocks #8562

Closed
Tracked by #8457
LHerskind opened this issue Sep 16, 2024 · 0 comments · Fixed by #8578
Closed
Tracked by #8457

refactor: Download only non-pruned blocks #8562

LHerskind opened this issue Sep 16, 2024 · 0 comments · Fixed by #8578
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Sep 16, 2024

Altering the L2BlockProposed event and using the lookup allows us to only look if we know there is something to find. To properly test, need to prune parts of the chain to see if we actually download it. This should be possible by extending the e2e_synching test with a chain of length 10 that is pruned back to 5, and then see that after synching we only have the first 5.

Note that we can do this without being able to handle re-orgs it is the fresh sync case from #8457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant