Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pxe to follow "fork-choice" of contract #8463

Closed
Tracked by #7614
LHerskind opened this issue Sep 9, 2024 · 1 comment · Fixed by #9913
Closed
Tracked by #7614

feat: pxe to follow "fork-choice" of contract #8463

LHerskind opened this issue Sep 9, 2024 · 1 comment · Fixed by #9913
Assignees
Milestone

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Sep 9, 2024

Along with #8457, the PXE should also take into account the re-orgs. Namely, if a note have been inserted during a block that is later pruned, we will need to also remove it from our PXE such that we don't think we could spend it later.

The exact mechanism for catching the re-orgs is to be decided, but could be as simple at storing the block number and expected archive along with the notes and then ask the node occaisionally if there have been any re-orgs and then delete if deeper than specified.

@LHerskind
Copy link
Contributor Author

Something to consider when working on this. It might be insufficient to rely on the archiver providing information around when it have seen a reorg, since a PXE might end up pointing at different nodes, which might have seen different reorgs.

It seems like the most stable method for figuring out if some information is indeed in the chain would be to store the block hashes as part of the note data on device, and then if that block is added to the proven chain mark is as included and periodically check the notes that don't have been marked.

@just-mitch just-mitch removed the P-high 🔥 Priority: high. Do this task next. label Nov 7, 2024
@just-mitch just-mitch changed the title feat: pxe to follow "fork-choice" of contract design: pxe to follow "fork-choice" of contract Nov 11, 2024
@just-mitch just-mitch changed the title design: pxe to follow "fork-choice" of contract feat: pxe to follow "fork-choice" of contract Nov 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants