fix(bb): eliminate recursion in accumulate* #8205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @fcarreiro and the rest of your teammates on |
fcarreiro
force-pushed
the
fc/bb-stack-overflow
branch
3 times, most recently
from
d0f3107 to
3b11930
Compare
|
As discussed, a helper for this constant range loop would help readability |
ludamad
reviewed
Aug 27, 2024
| auto seq = std::make_index_sequence<NUM_RELATIONS>{}; | ||
| // This evaluates the function across the relations, without recursion. | ||
| [&]<size_t... I>(std::index_sequence<I...>) { | ||
| // FIXME: You wan't /*consider_skipping=*/false here, but tests need to be fixed. |
There was a problem hiding this comment.
Not sure I get this, and why not fix the test if so?
There was a problem hiding this comment.
I don't have the time, like 20 verification tests fail. Cody said Luke will look at it.
There was a problem hiding this comment.
Yeah it wasn't immediately obvious to me what the issue is so I thought Luke should have a look.
fcarreiro
force-pushed
the
fc/bb-stack-overflow
branch
from
3b11930 to
0adca16
Compare
ludamad
approved these changes
Aug 27, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jean is working on the AVM recursive verifier and he found that these functions were executed recursively (the compiler was indeed generating recursive calls) and causing a stack overflow. This fixes that.
Also fixedTests fail with the fix, I've added a comment.accumulate_relation_evaluations_without_skippingwhich was only not skipping the first relation.const&. IIUC they were being copied before which can be massive for the typeAllValues. Not sure about that but you might want to check the callers, etc.