refactor(Protogalaxy): Isolate some state and clarify skipped zero computation #8173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codygunton
force-pushed
the
cg/pg-state-1
branch
from
80aac0a to
6e8ffe6
Compare
codygunton
changed the title
codygunton
changed the title
codygunton
changed the title
ledwards2225
approved these changes
Aug 26, 2024
| @@ -56,7 +56,7 @@ TEST(Protogalaxy, CombinerOn2Instances) | |||
| ProverInstances instances{ instance_data }; | |||
| instances.alphas.fill(bb::Univariate<FF, 12>(FF(0))); // focus on the arithmetic relation only | |||
| auto pow_polynomial = PowPolynomial(std::vector<FF>{ 2 }); | |||
| auto result = prover.compute_combiner</*OptimisationEnabled=*/false>(instances, pow_polynomial); | |||
| auto result = Fun::compute_combiner(instances, pow_polynomial, prover.state.univariate_accumulators); | |||
There was a problem hiding this comment.
big proponent of this as you know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some steps toward clarifying state during Protogalaxy proof construction:
The next step will be to reduce the amount of state in ProverInstances.