fix: Add checks for arg-type #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
approved these changes
May 22, 2023
rahul-kothari
force-pushed
the
lh/611-encode-arguments
branch
from
f372084 to
6921cb9
Compare
|
@LHerskind there was an E2E test I found where we were still encoding even though it is not required anymore. Idk if there are anymore places though. (I simply searched for all instances where we call methods on a contract i.e. by searching for |
rahul-kothari
approved these changes
May 22, 2023
jeanmon
pushed a commit
that referenced
this pull request
May 23, 2023
* fix: Add checks for arg-type * fix: support arg of 'number' type * fix: correct wrapped fr in acir sim * no need to force encode in some e2e tests! --------- Co-authored-by: Maddiaa0 <[email protected]> Co-authored-by: Rahul Kothari <[email protected]>
suyash67
pushed a commit
that referenced
this pull request
May 25, 2023
* prelim / very-broken commit where Jean and I started implementing the initial private kernel and moving logic between it and the inner kernel * wip - fix some compilation issues, remove unused imports, remove update_end_values leftover * wip - some minor changes and comments after pairing with David * wip: additional compilation fixes * Refactor helper functions in private kernel tests * wip - Fix linking issue and comment out some tests * wip - repair native and circuit tests * wip - include using double quotes and remove unused code * wip - fixing circuit_create_proof_cbinds test and adapting private_kernel_sim function to the inner/init split * wip - fix clang tidy issue * wip - post master merger fixes and remove test on new nullifiers * wip - fix clang tidy issue * wip - fix clang tidy issue * wip - fix typescript tests and data structure split * wip - format typescript * wip - replace CONSTRUCTOR_ARGS by FUNCTION_ARGS * wip - add nullifier and l1-l2-message tree roots in initial private kernel circuit * wip - post merge fix * Migrate common.hpp functions into non-templated ones * refactor(sol): use Hash.sha256ToField library where required (#637) * refactor(sol): use Hash.sha256ToField library where required * fmt :) * feat: expose bytes32 hash directly * fmt: https://i.pinimg.com/originals/81/23/a1/8123a132c007eab782d6ca9bed517eb3.jpg --------- Co-authored-by: Maddiaa0 <[email protected]> * fix: Add checks for arg-type (#638) * fix: Add checks for arg-type * fix: support arg of 'number' type * fix: correct wrapped fr in acir sim * no need to force encode in some e2e tests! --------- Co-authored-by: Maddiaa0 <[email protected]> Co-authored-by: Rahul Kothari <[email protected]> * fix: naming consistency in messaging (messageHash -> message) (#641) * fix: contentHash -> content * fix: update content in nr * fix: update incorrect message hash naming --------- Co-authored-by: Maddiaa0 <[email protected]> * chore: remove unknown casts in archiver test (#648) Removes intermediate casts to unknown from archiver test, which hide type errors in the args of the mocked event. * Consolidation code for contract_logic * e2e fixing: Initialise public and private call stack and comment out some checks * Renaming file native_private_kernel_initial.XPP into native_private_kernel_init.XPP * Rename native_private_kernel_circuit into native_private_kernel_circuit_inner * Simplify if/else clause on deployment contract boolean in contract logic * abis test snapshot - restore from master for vk hash * Remove old TODO comments * Fork FUNCTION_ARGS into FUNCTION/CONSTRUCTOR_ARGS generator indices * Move code copying public/private_call_stack in PKC init * Clang tidy fix * Add clarifications into a comment * Added comments * remove empty lines --------- Co-authored-by: jeanmon <[email protected]> Co-authored-by: Maddiaa <[email protected]> Co-authored-by: Maddiaa0 <[email protected]> Co-authored-by: Lasse Herskind <[email protected]> Co-authored-by: Rahul Kothari <[email protected]> Co-authored-by: Santiago Palladino <[email protected]>
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #611
Extends
encodeArgument()for thefieldcase to supportargofnumber,bigint,Fieldor types that implement atoField()function.Note that it will insert
argdirectly ifarg != bigint && !arg.toField().Checklist: