Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fixed_base_scalar_mul.rs #6058

Closed
benesjan opened this issue Apr 26, 2024 · 1 comment
Closed

Rename fixed_base_scalar_mul.rs #6058

benesjan opened this issue Apr 26, 2024 · 1 comment
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Apr 26, 2024 •
edited
Loading

The file now contains not just fixed_base_scalar_mul function but also embedded_curve_add and variable_base_scalar_mul. It should be renamed to something more generic.

Rename the following 2 files:
noir/noir-repo/acvm-repo/acvm/src/pwg/blackbox/fixed_base_scalar_mul.rs
noir/noir-repo/acvm-repo/bn254_blackbox_solver/src/fixed_base_scalar_mul.rs
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 26, 2024
@benesjan benesjan self-assigned this Apr 26, 2024
@benesjan
Copy link
Contributor Author

Replaced with noir-lang/noir#4932

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benesjan