Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dont build tests in non assert wasm build #532

Merged
merged 1 commit into from
May 9, 2023
Merged

feat: dont build tests in non assert wasm build #532

merged 1 commit into from
May 9, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented May 9, 2023

Description

Cuts about a minute and a half off the build time

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 requested a review from dbanks12 May 9, 2023 18:11
dbanks12
dbanks12 approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dbanks12
Copy link
Collaborator

dbanks12 commented May 9, 2023

All of the CI has passed, but for some reason Github is showing them as still running. Going to merge.

@dbanks12 dbanks12 merged commit 32b0cd2 into master May 9, 2023
@dbanks12 dbanks12 deleted the md/wasm-build branch May 9, 2023 19:07
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maddiaa0 @dbanks12