Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(avm): go back to single value sstore / sloads, rather than arrays #5028

Closed
Maddiaa0 opened this issue Mar 7, 2024 · 2 comments
Closed

fix(avm): go back to single value sstore / sloads, rather than arrays #5028

Maddiaa0 opened this issue Mar 7, 2024 · 2 comments
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Mar 7, 2024

In #5027 a fix was introduced to move storage write / read to use arrays ( like they had previously done ) as using loops instead caused ssa codegen bugs.
@Maddiaa0 Maddiaa0 added the C-avm Component: AVM related tickets (aka public VM) label Mar 7, 2024
@Maddiaa0 Maddiaa0 added this to A3 Mar 7, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 7, 2024
@fcarreiro
Copy link
Contributor

@dbanks12 we have this bug. Update on the situation: the AVM circuit now handles arrays IIUC. Maybe it's worth just leaving it with arrays since it will likely result in shorter bytecode and lower cost. To be decided.

@Maddiaa0
Copy link
Member Author

Maddiaa0 commented Oct 2, 2024

closed by #8264

@Maddiaa0 Maddiaa0 closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcarreiro @Maddiaa0