Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contract-deploy] Verify executed bytecode in PXE #4435

Closed
Tracked by #4052
spalladino opened this issue Feb 5, 2024 · 1 comment
Closed
Tracked by #4052

[contract-deploy] Verify executed bytecode in PXE #4435

spalladino opened this issue Feb 5, 2024 · 1 comment

Comments

@spalladino
Copy link
Collaborator

spalladino commented Feb 5, 2024

The PXE should use the address' class.artifactHash to check that the bytecode it's going to execute matches the intended one. This check should be done either before calling the simulator, or when a new contract artifact is added to the PXE.

@spalladino
Copy link
Collaborator Author

spalladino commented Mar 18, 2024

Not required. The PXE computes the class id from the entire artifact hash, which includes private function bytecode. Changing the bytecode would change the class id.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 18, 2024
@spalladino spalladino reopened this Mar 18, 2024
@spalladino spalladino closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant