Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how much should we constrain about counters in the private kernel #4211

Open
sirasistant opened this issue Jan 25, 2024 · 2 comments
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@sirasistant
Copy link
Collaborator

sirasistant commented Jan 25, 2024

Currently, the private kernel trusts the counters issued by functions. We should consider wether:

  • We should check that for any given call all its sideffects are within the call boundaries (start and end) (I think yes)
  • We should check that for any given call all of its nested calls have assigned boundaries that don't overlap with each other
  • We should check that for any given call all of the sideffects it generates don't fall into the boundaries of nested calls
  • We should check that all counters are strictly increasing (no idea how to verify this in the kernel circuit)
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 25, 2024
@sirasistant sirasistant added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Jan 25, 2024
@iAmMichaelConnor
Copy link
Contributor

I think Leila summarised most of these checks in the draft spec too, if I'm not mistaken: https://yp-aztec.netlify.app/docs/circuits/private-kernel-initial#verifying-the-counters

@sirasistant
Copy link
Collaborator Author

After this PR: #6365 we are doing the first two bullet points of the list 🎉 . Doing the latter two shouldn't be necessary since all transient data that can be read is siloed, but it's something to keep in mind in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
Status: Todo
Development

No branches or pull requests

2 participants