Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate L2 -> L1 messages #381

Closed
3 tasks
LHerskind opened this issue Apr 26, 2023 · 2 comments · Fixed by #469
Closed
3 tasks

Propagate L2 -> L1 messages #381

LHerskind opened this issue Apr 26, 2023 · 2 comments · Fixed by #469
Assignees

Comments

@LHerskind
Copy link
Contributor

For L2 contracts that are transmitting messages to L1, we must take the L2 messages published as part of the kernel, and include it in the calldata hash. Likewise, it needs to be included in the L2 block that are inputted into the contract to update its method of deriving calldatahashes for the kernels

Require updates to:

  • Circuits
  • Contracts
  • Typescript
@LHerskind LHerskind added this to A3 Apr 11, 2023
@LHerskind LHerskind converted this from a draft issue Apr 26, 2023
@LHerskind LHerskind self-assigned this Apr 26, 2023
@LHerskind LHerskind mentioned this issue Apr 26, 2023
6 tasks
@LHerskind
Copy link
Contributor Author

Blocked by BB using different generators for WASM and CPP. Similar expected for #348.

@LHerskind LHerskind moved this from Todo to Blocked in A3 Apr 28, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📤 L2->L1 Calls milestone May 1, 2023
This was referenced May 2, 2023
@LHerskind LHerskind moved this from Blocked to In Progress in A3 May 5, 2023
@LHerskind
Copy link
Contributor Author

Can be doen without WASM and CPP parity, it is simply more ugly from my POV.

@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 May 5, 2023
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants