Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noir-compiler should have better support for mixed remote and relative dependencies #3646

Closed
alexghr opened this issue Dec 11, 2023 · 1 comment

Comments

@alexghr
Copy link
Contributor

alexghr commented Dec 11, 2023

Prior to #3604 the dependency manager in noir-compiler would selectively unarchive the libraries listed in a Nargo.toml and this worked well as long as the top-level Nargo.toml listed all dependencies to be extracted from a particular archive.

This stopped working once aztec.nr added a 'private' dependency on noir-protocol-circuits. The dependency manager would extract aztec.nr from aztec-packages but when it compiled it, the compiler couldn't find ../../noir-protocol-circuits, so #3604 we've removed the optimisation and now the whole archiver is extracted, which should create the exact tree hierarchy required by libraries.

We should look for a better solution than extracing the whole archive (e.g. depending on aztec.nr inside aztec-packages would extract 80MB of code that's not used in compiling noir contracts).

@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 11, 2023
@PhilWindle PhilWindle closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 3, 2024
@alexghr
Copy link
Contributor Author

alexghr commented Jan 3, 2024

with the activity around aztec-nargo, it doesn't make sense to pursue this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants