Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli unbox token #3003

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: cli unbox token #3003

merged 1 commit into from
Oct 24, 2023

Conversation

benesjan
Copy link
Contributor

Token box was broken after unboxing because authwit and safe_math deps were not updated.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan enabled auto-merge (squash) October 24, 2023 14:19
@benesjan benesjan changed the title fix: TokenBox fix: cli unbox token Oct 24, 2023
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_history_successful_decrypting_time_in_ms (5): 2,493 (-59%)
  • note_history_successful_decrypting_time_in_ms (10): 4,894 (-59%)
  • l2_block_public_tx_process_time_in_ms (8): 1,324 (-48%)
  • l2_block_public_tx_process_time_in_ms (32): 5,271 (-48%)
  • l2_block_public_tx_process_time_in_ms (128): 21,269 (-47%)
  • note_successful_decrypting_time_in_ms (8): 340 (-52%)
  • note_successful_decrypting_time_in_ms (32): 1,310 (-48%)
  • note_successful_decrypting_time_in_ms (128): 3,883 (-60%)
  • note_trial_decrypting_time_in_ms (8): 41.0 (+925%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit c50aefb6 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,984 868,280 3,449,408
l1_rollup_execution_gas 842,071 3,595,388 22,204,777
l2_block_processing_time_in_ms 2,310 (+1%) 8,717 (-1%) 34,445
note_successful_decrypting_time_in_ms ⚠️ 340 (-52%) ⚠️ 1,310 (-48%) ⚠️ 3,883 (-60%)
note_trial_decrypting_time_in_ms ⚠️ 41.0 (+925%) 107 (+2%) 137 (+1%)
l2_block_building_time_in_ms 14,670 (-7%) 58,153 (-7%) 232,506 (-8%)
l2_block_rollup_simulation_time_in_ms 13,305 (+1%) 52,758 210,785
l2_block_public_tx_process_time_in_ms ⚠️ 1,324 (-48%) ⚠️ 5,271 (-48%) ⚠️ 21,269 (-47%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 24,669 (-1%) 47,985 (-1%)
note_history_successful_decrypting_time_in_ms ⚠️ 2,493 (-59%) ⚠️ 4,894 (-59%)
note_history_trial_decrypting_time_in_ms 122 (+1%) 147 (+1%)
node_database_size_in_bytes 1,630,492 1,098,366
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 82.4 61,697 18,841
private-kernel-ordering 50.5 24,233 8,089
base-rollup 2,087 656,309 811
root-rollup 89.3 (-3%) 4,072 1,097
private-kernel-inner 59.1 81,504 18,841
public-kernel-private-input 47.0 (+1%) 41,455 18,841
public-kernel-non-first-iteration 29.1 41,497 18,841
merge-rollup 0.913 (+6%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 29,393

@benesjan benesjan merged commit 1ad6647 into master Oct 24, 2023
3 checks passed
@benesjan benesjan deleted the janb/unbox-fix branch October 24, 2023 14:43
kevaundray pushed a commit that referenced this pull request Oct 24, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.11.0</summary>

##
[0.11.0](aztec-packages-v0.10.1...aztec-packages-v0.11.0)
(2023-10-24)


### ⚠ BREAKING CHANGES

* consistent `deploy` method params
([#2975](#2975))

### Features

* Consistent `deploy` method params
([#2975](#2975))
([c50aefb](c50aefb))
* Pedersen hash in acir format
([#2990](#2990))
([2a4c548](2a4c548))


### Bug Fixes

* TokenBox
([#3003](#3003))
([1ad6647](1ad6647))


### Miscellaneous

* Update acir_tests reference branch
([#2993](#2993))
([91813a5](91813a5))
</details>

<details><summary>barretenberg.js: 0.11.0</summary>

##
[0.11.0](barretenberg.js-v0.10.1...barretenberg.js-v0.11.0)
(2023-10-24)


### Features

* Pedersen hash in acir format
([#2990](#2990))
([2a4c548](2a4c548))
</details>

<details><summary>barretenberg: 0.11.0</summary>

##
[0.11.0](barretenberg-v0.10.1...barretenberg-v0.11.0)
(2023-10-24)


### Features

* Pedersen hash in acir format
([#2990](#2990))
([2a4c548](2a4c548))


### Miscellaneous

* Update acir_tests reference branch
([#2993](#2993))
([91813a5](91813a5))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0 pushed a commit that referenced this pull request Oct 25, 2023
Token box was broken after unboxing because authwit and safe_math deps
were not updated.
Maddiaa0 pushed a commit that referenced this pull request Oct 25, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.11.0</summary>

##
[0.11.0](aztec-packages-v0.10.1...aztec-packages-v0.11.0)
(2023-10-24)


### ⚠ BREAKING CHANGES

* consistent `deploy` method params
([#2975](#2975))

### Features

* Consistent `deploy` method params
([#2975](#2975))
([c50aefb](c50aefb))
* Pedersen hash in acir format
([#2990](#2990))
([2a4c548](2a4c548))


### Bug Fixes

* TokenBox
([#3003](#3003))
([1ad6647](1ad6647))


### Miscellaneous

* Update acir_tests reference branch
([#2993](#2993))
([91813a5](91813a5))
</details>

<details><summary>barretenberg.js: 0.11.0</summary>

##
[0.11.0](barretenberg.js-v0.10.1...barretenberg.js-v0.11.0)
(2023-10-24)


### Features

* Pedersen hash in acir format
([#2990](#2990))
([2a4c548](2a4c548))
</details>

<details><summary>barretenberg: 0.11.0</summary>

##
[0.11.0](barretenberg-v0.10.1...barretenberg-v0.11.0)
(2023-10-24)


### Features

* Pedersen hash in acir format
([#2990](#2990))
([2a4c548](2a4c548))


### Miscellaneous

* Update acir_tests reference branch
([#2993](#2993))
([91813a5](91813a5))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 27, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.11.0</summary>

##
[0.11.0](AztecProtocol/aztec-packages@aztec-packages-v0.10.1...aztec-packages-v0.11.0)
(2023-10-24)


### ⚠ BREAKING CHANGES

* consistent `deploy` method params
([#2975](AztecProtocol/aztec-packages#2975))

### Features

* Consistent `deploy` method params
([#2975](AztecProtocol/aztec-packages#2975))
([c50aefb](AztecProtocol/aztec-packages@c50aefb))
* Pedersen hash in acir format
([#2990](AztecProtocol/aztec-packages#2990))
([2a4c548](AztecProtocol/aztec-packages@2a4c548))


### Bug Fixes

* TokenBox
([#3003](AztecProtocol/aztec-packages#3003))
([1ad6647](AztecProtocol/aztec-packages@1ad6647))


### Miscellaneous

* Update acir_tests reference branch
([#2993](AztecProtocol/aztec-packages#2993))
([91813a5](AztecProtocol/aztec-packages@91813a5))
</details>

<details><summary>barretenberg.js: 0.11.0</summary>

##
[0.11.0](AztecProtocol/aztec-packages@barretenberg.js-v0.10.1...barretenberg.js-v0.11.0)
(2023-10-24)


### Features

* Pedersen hash in acir format
([#2990](AztecProtocol/aztec-packages#2990))
([2a4c548](AztecProtocol/aztec-packages@2a4c548))
</details>

<details><summary>barretenberg: 0.11.0</summary>

##
[0.11.0](AztecProtocol/aztec-packages@barretenberg-v0.10.1...barretenberg-v0.11.0)
(2023-10-24)


### Features

* Pedersen hash in acir format
([#2990](AztecProtocol/aztec-packages#2990))
([2a4c548](AztecProtocol/aztec-packages@2a4c548))


### Miscellaneous

* Update acir_tests reference branch
([#2993](AztecProtocol/aztec-packages#2993))
([91813a5](AztecProtocol/aztec-packages@91813a5))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants